Do not ignore "Image out-of-sync" internal LVs #709
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are still "valid" existing internal RAID LVs just not synced yet.
vojtechtrefny
force-pushed
the
3.1-devel_lvm-out-of-sync-images
branch
from
f1cc2e3 to
46580db
Compare
|
Is it possible to apply this to 3.0-devel instead? |
|
New PR for 3.0-devel: #710 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are still "valid" existing internal RAID LVs just not synced
yet.
We are using internal lvs to calculate
free_spaceproperty of vgs. If we ignore these we will report wrong free space, see storaged-project/blivet-gui#107There is also an issue in lvmdbus (https://bugzilla.redhat.com/show_bug.cgi?id=1608930) -- it doesn't update the Attr property of the LVs so we ignore all internal lvs for raid LVs (because the type is never changed from (I)mage out-of-sync to (i)mage, mirror or raid).